Add clusterrolebinding to allow kube-rbac-proxy verify tokens #12042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verification Signed-off-by: ArthurSens <arthursens2005@gmail.com>
Signed-off-by: ArthurSens <arthursens2005@gmail.com>
|
started the job as gitpod-build-as-content-rbac.6 because the annotations in the pull request description changed |
github-actions
bot
added
team: delivery
vulkoingim
approved these changes
Aug 10, 2022
jenting
approved these changes
Aug 10, 2022
roboquat
added
the
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #11782 I've added kube-rbac-proxy to content-service because Prometheus was not able to reach the metrics endpoint of content-service.
After this change got deployed, the error only changed to another one. We're now getting
401 Unathorizederrors.Looks like I forgot to add the role binding that authorizes kube-rbac-proxy to actually verify valid tokens.
Related Issue(s)
Solves alerts like this one.
How to test
You can connect to the preview of this PR, port-forward prometheus and verify that content-service is being scraped successfully at the page
/targetsRelease Notes
Werft options: