Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid displaying prebuild-related workspaces in the workspaces list from JetBrains Gateway #12074

Merged

Conversation

felladrin
Copy link
Contributor

Description

These changes ensure that only regular workspaces are added to the workspaces list from JetBrains Gateway.

Related Issue(s)

Fixes #11450

How to test

  1. Ensure you have the latest JetBrains Gateway installed.
  2. Download the plugin build related to this branch in Dev Versions, and install it on the Gateway.
  3. Start a manual prebuild of one of your workspaces.
  4. Confirm the Prebuild instance doesn't appear on the workspaces list from JetBrains Gateway.
    • Note: After the prebuild finishes, it will open the workspace. At this moment, it's fine the workspace appears in the list, as now it's a regular workspace that is starting.

Release Notes

NONE

Copy link
Contributor

@andreafalzetti andreafalzetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works as advertised 🎉

@roboquat roboquat merged commit 6a52dbf into main Aug 11, 2022
@roboquat roboquat deleted the felladrin/11450-fix-workspaces-list-on-jetbrains-gateway branch August 11, 2022 19:23
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: jetbrains release-note-none size/S team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JetBrains Gateway displays headless workspaces when prebuilds are triggered
3 participants