Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace integration tests: Improve message when preview env build job fails #12081

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

mads-hartmann
Copy link
Contributor

@mads-hartmann mads-hartmann commented Aug 12, 2022

Description

This PR:

  • Improves the error message when the integration tests fail due to a failed build for the preview environment (see example here - in 'How to test' you can see how I got the build job to fail to trigger this error case)
  • Adds a clarify comment that explains why you see two Werft jobs for the integration test brach.
  • I wasn't able to reproduce the dual slack messages that Kyle reported for job gitpod-custom-main.132 (here and here). I thought it might be due to the cleanup handler being invoked multiple times so I added a bit of logging so we can see if that's the case the next time.

Related Issue(s)

Fixes #11979

How to test

To trigger the scenario where the build job fails for the preview environment I manually killed the job while the integration test was running:

kubectl --context=dev -n werft delete pod gitpod-build-wk-inte-test-20220812064312.0

See the logs here

Release Notes

NONE

Documentation

N/A

Werft options:

  • /werft with-preview

@roboquat roboquat added size/M and removed size/S labels Aug 12, 2022
@mads-hartmann mads-hartmann marked this pull request as ready for review August 12, 2022 08:36
@mads-hartmann mads-hartmann requested a review from a team August 12, 2022 08:36
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Aug 12, 2022
@roboquat roboquat merged commit 698e6bf into main Aug 12, 2022
@roboquat roboquat deleted the mads/clarify-workspace-integration-tests branch August 12, 2022 10:45
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The workspace integration tests failed because of grpc timeout
3 participants