Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[registry-facade] Improve IPFS logging #12101

Merged
merged 1 commit into from
Aug 12, 2022
Merged

[registry-facade] Improve IPFS logging #12101

merged 1 commit into from
Aug 12, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 12, 2022

Description

IPFS client should respect log levels.

How to test

  • Enable IPFS
  • Open a workspace
  • Check registry-facade logs and confirm there are no entries similar to

{"level":"info","message":"[DEBUG] POST http://ipfs.storage:9095/api/v0/cat?arg=%2Fipfs%2Fbafkreigmgbjgwxkqco552ec4h2rx7cjdytiyhnca77uha7msl6g7rjctfq","serviceContext":{"service":"registry-facade","version":"commit-4e941c628adc62d67b67d39df1765152f34ba703"},"severity":"INFO","time":"2022-08-12T14:47:51Z"}

Release Notes

NONE

Werft options:

  • /werft with-preview

@aledbf aledbf marked this pull request as ready for review August 12, 2022 15:37
@aledbf aledbf requested a review from a team August 12, 2022 15:37
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Aug 12, 2022
@roboquat roboquat merged commit c0c0d7e into main Aug 12, 2022
@roboquat roboquat deleted the aledbf/regip branch August 12, 2022 17:58
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants