Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] allow to open desktop links on app domain #12102

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Aug 12, 2022

Description

It is supporting PR for #12082. It should be deployed by the webapp team before.

Related Issue(s)

Fixes #

How to test

Test #12082

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@akosyakov akosyakov requested a review from a team August 12, 2022 15:42
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Aug 12, 2022
@laushinka laushinka self-assigned this Aug 15, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-ak-open-desktop-link.1 because the annotations in the pull request description changed
(with .werft/ from main)

@laushinka
Copy link
Contributor

@akosyakov I followed the steps here, but when I opened another workspace, I was still prompted by the pop-up.

Screenshot 2022-08-15 at 13 15 43

.

@akosyakov
Copy link
Member Author

@laushinka you should use prev env of another PR. This PR only bring necessary changes which should be deployed before by webapp team.

@laushinka
Copy link
Contributor

@laushinka you should use prev env of another PR

@akosyakov I guess this PR is already tested and reviewed. What behavior should I test on this one?

@akosyakov
Copy link
Member Author

akosyakov commented Aug 15, 2022

@akosyakov I guess #12082 is already tested and reviewed. What behavior should I test on this one?

mostly code review, you can check for regressions but you did it already, ie it still works like on main

if all good I would generally approve and /hold on new line to let author address typos, nits and merge later 🙏🏻

@laushinka
Copy link
Contributor

Approving with a hold to address comments later.

/hold

@akosyakov
Copy link
Member Author

/unhold

@roboquat roboquat merged commit f69e6d4 into main Aug 15, 2022
@roboquat roboquat deleted the ak/open_desktop_link branch August 15, 2022 12:25
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants