Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[usage] Use actual date for start time #12123

Merged
merged 1 commit into from
Aug 15, 2022
Merged

[usage] Use actual date for start time #12123

merged 1 commit into from
Aug 15, 2022

Conversation

laushinka
Copy link
Contributor

@laushinka laushinka commented Aug 14, 2022 •
edited

Description

Shows the actual time instead of "... ago"

Before After
Screenshot 2022-08-15 at 01 39 03 Screenshot 2022-08-15 at 01 38 13

Related Issue(s)

Relates #12090 and #11640

How to test

  1. Join the team
  2. Go to https://lau-show-actual-time.preview.gitpod-dev.com/t/gitpod/usage
  3. See the actual date and time.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview
  • /werft with-payment

@laushinka laushinka mentioned this pull request Aug 14, 2022
Closed
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-lau-show-actual-time.2 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat added size/M and removed size/XS labels Aug 14, 2022
@roboquat roboquat added size/S and removed size/M labels Aug 14, 2022
@laushinka laushinka marked this pull request as ready for review August 14, 2022 22:35
@laushinka laushinka requested a review from a team August 14, 2022 22:35
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Aug 14, 2022
jldec
jldec approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@jldec jldec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laushinka - looks good
Let's used the "short" (3-letter) month string instead of long to match proposed design

@roboquat roboquat merged commit b09264b into main Aug 15, 2022
@roboquat roboquat deleted the lau/show-actual-time branch August 15, 2022 10:04
@laushinka
Copy link
Contributor Author

laushinka commented Aug 15, 2022 •
edited by werft-gitpod-dev-com bot

Let's used the "short" (3-letter) month string instead of long to match proposed design

Thanks for the 👍🏼 Will do the short string as a drive-by in the workspace details issue 🙏🏽

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jldec jldec jldec approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@laushinka @jldec @roboquat