Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[billing] Check if network connections should be limited #12162

Merged
merged 2 commits into from
Aug 17, 2022
Merged

[billing] Check if network connections should be limited #12162

merged 2 commits into from
Aug 17, 2022

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Aug 16, 2022

Description

If a user is on the free tier, we want to limit the network connections that they can create.

Related Issue(s)

Fixes #12161)

Release Notes

None

Werft options:

  • /werft with-preview

@Furisto Furisto marked this pull request as ready for review August 16, 2022 17:00
@Furisto Furisto requested a review from a team August 16, 2022 17:01
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Aug 16, 2022
geropl
geropl approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @Furisto, code LGTM!

/hold
Took the liberty to push a commit on top, please unhold if you're fine with that.

@Furisto
Copy link
Member Author

Furisto commented Aug 17, 2022

/unhold

@roboquat roboquat merged commit 78a0bf5 into main Aug 17, 2022
@roboquat roboquat deleted the fo/netlimit-free-tier branch August 17, 2022 08:31
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Aug 18, 2022
@Furisto Furisto mentioned this pull request Aug 22, 2022
Merged
1 task
@Furisto Furisto self-assigned this Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees

@Furisto Furisto

Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production feature: connection-limiting release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Limit network connections of users on the free tier
3 participants
@Furisto @geropl @roboquat