Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer]: remove all podsecuritypolicies #12173

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Aug 17, 2022

Description

This is deprecated in Kubernetes 1.21 and removed in 1.25 and it's not really used in this setup

Related Issue(s)

Fixes #6176

How to test

Deploy via KOTS. Have tried with k3s, AKS and GKE and all works fine

Release Notes

[installer]: remove all podsecuritypolicies

Documentation

Werft options:

  • /werft with-preview

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-sje-installer-psp-removal.2 because the annotations in the pull request description changed
(with .werft/ from main)

@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Aug 17, 2022

/werft run publish-to-kots

👍 started the job as gitpod-build-sje-installer-psp-removal.4
(with .werft/ from main)

@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Aug 17, 2022

/werft run publish-to-kots

👍 started the job as gitpod-build-sje-installer-psp-removal.6
(with .werft/ from main)

@mrsimonemms mrsimonemms marked this pull request as ready for review August 17, 2022 13:02
@mrsimonemms mrsimonemms requested review from a team August 17, 2022 13:02
@github-actions github-actions bot added team: delivery Issue belongs to the self-hosted team team: workspace Issue belongs to the Workspace team labels Aug 17, 2022
@corneliusludmann
Copy link
Contributor

For your all information: #6176 (comment)

@csweichel
Copy link
Contributor

cc @gitpod-io/engineering-workspace

Copy link
Contributor

@corneliusludmann corneliusludmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my (Team Self-Hosted) perspective. However, would be good if Team Workspace could do an extensive review here.

Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd defer to @aledbf review and approve

Simon Emms added 2 commits August 22, 2022 07:01
This is deprecated in kubernetes 1.21 and removed in 1.25 and it's not
really used in this setup
@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Aug 22, 2022

/werft run publish-to-kots

👍 started the job as gitpod-build-sje-installer-psp-removal.8
(with .werft/ from main)

@aledbf aledbf self-requested a review August 22, 2022 13:00
@roboquat roboquat merged commit 8063b10 into main Aug 22, 2022
@roboquat roboquat deleted the sje/installer-psp-removal branch August 22, 2022 13:00
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production release-note size/XXL team: delivery Issue belongs to the self-hosted team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Installer]: PodSecurityPolicies now deprecated - explore replacements
6 participants