Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code] build stable code image for 1.70.2 #12186

Merged
merged 1 commit into from
Aug 18, 2022
Merged

[code] build stable code image for 1.70.2 #12186

merged 1 commit into from
Aug 18, 2022

Conversation

jeanp413
Copy link
Member

Description

Build code image for 1.70.2

Related Issue(s)

Related #11638

How to test

  • Check about dialog says 1.70.2

Release Notes

NONE

Werft options:

  • /werft with-preview

@jeanp413
Copy link
Member Author

jeanp413 commented Aug 18, 2022 •
edited by werft-gitpod-dev-com bot

/werft run

👍 started the job as gitpod-build-jp-vscode-172-build.1
(with .werft/ from main)

@jeanp413
Copy link
Member Author

jeanp413 commented Aug 18, 2022 •
edited by werft-gitpod-dev-com bot

/werft run

👍 started the job as gitpod-build-jp-vscode-172-build.2
(with .werft/ from main)

@akosyakov akosyakov requested review from filiptronicek and a team August 18, 2022 09:07
@filiptronicek
Copy link
Member

filiptronicek commented Aug 18, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-clean-slate

👍 started the job as gitpod-build-jp-vscode-172-build.3
(with .werft/ from main)

@andreafalzetti
Copy link
Contributor

andreafalzetti commented Aug 18, 2022 •
edited by werft-gitpod-dev-com bot

/werft run

👍 started the job as gitpod-build-jp-vscode-172-build.4
(with .werft/ from main)

@jeanp413
Copy link
Member Author

jeanp413 commented Aug 18, 2022 •
edited by werft-gitpod-dev-com bot

/werft run

👍 started the job as gitpod-build-jp-vscode-172-build.5
(with .werft/ from main)

@vulkoingim
Copy link
Contributor

vulkoingim commented Aug 18, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-preview

👍 started the job as gitpod-build-jp-vscode-172-build.6
(with .werft/ from main)

@jeanp413
Copy link
Member Author

jeanp413 commented Aug 18, 2022 •
edited

@filiptronicek could you approve 🙏

filiptronicek
filiptronicek approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good bud! (SHA checks out)
image

@roboquat roboquat merged commit 0dcb61e into main Aug 18, 2022
@roboquat roboquat deleted the jp/vscode-172-build branch August 18, 2022 20:00
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filiptronicek filiptronicek filiptronicek approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/XS team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jeanp413 @filiptronicek @andreafalzetti @vulkoingim @roboquat