ws-manager: Replace initializerMapLock with sync.Map #12215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-to-syncmap.1 because the annotations in the pull request description changed |
sagor999
suggested changes
Aug 19, 2022
jenting
reviewed
Aug 22, 2022
|
/werft run 👍 started the job as gitpod-build-to-syncmap.3 |
sagor999
approved these changes
Aug 22, 2022
This was referenced Aug 23, 2022
Merged
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were several workspaces content-initializer was taking a very long time to start. 1
As a result, it seemed that stop requests sometimes came before the content-initializer.2
If content-initializer runs on ws-daemon after the workspace pod has disappeared, it should not work well because there should be no workspace directory. The lock on the initializerMap was common in ws-manager. This could cause longer locks and slower content-initializer startup. This has been improved.
Related Issue(s)
Fixes #11852
How to test
Do you know good way?
Release Notes
Documentation
Werft options:
Footnotes
internal log1 ↩
internal log2 ↩