[usage] Add config for billInstancesAfter #12257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
reviewed
Aug 22, 2022
| @@ -243,6 +243,7 @@ EOF`); | |||
| private configureUsage(slice: string) { | |||
| exec(`yq w -i ${this.options.installerConfigPath} experimental.webapp.usage.enabled true`, { slice: slice }) | |||
| exec(`yq w -i ${this.options.installerConfigPath} experimental.webapp.usage.schedule 1m`, { slice: slice }) | |||
| exec(`yq w -i ${this.options.installerConfigPath} experimental.webapp.usage.billInstancesAfter "2022-08-11T08:05:32.499Z"`, { slice: slice }) | |||
There was a problem hiding this comment.
How was this value determined? Is this value still appropriate given current contexts?
There was a problem hiding this comment.
This is the context for the value.
easyCZ
approved these changes
Aug 22, 2022
easyCZ
reviewed
Aug 22, 2022
| @@ -4,6 +4,7 @@ | |||
| "default": 0.1666666667, | |||
| "gitpodio-internal-xl": 0.3333333333 | |||
| }, | |||
| "billInstancesAfter":"2022-08-11T08:05:32.499Z", | |||
There was a problem hiding this comment.
[nit] Space after colon
Suggested change
| "billInstancesAfter":"2022-08-11T08:05:32.499Z", | |
| "billInstancesAfter": "2022-08-11T08:05:32.499Z", |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This sets the preview environment config for
billInstancesAfterto be as mentioned here.For staging and prod will be PRs against the Ops repo.
Related Issue(s)
Relates #12223
How to test
kubectl get podskubectl logs -f [USAGE-POD]billInstancesAfterwith the specified value.Release Notes
Documentation
Werft options: