add support for aborting workspaces #12284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aledbf
approved these changes
Aug 23, 2022
roboquat
added
deployed: workspace
svenefftinge
added a commit
that referenced
this pull request
Aug 25, 2022
use the new StopWorkspacePolicy introduced with #12284 to avoid spending resources on backing up discarded prebuilds.
1 task
svenefftinge
added a commit
that referenced
this pull request
Sep 6, 2022
use the new StopWorkspacePolicy introduced with #12284 to avoid spending resources on backing up discarded prebuilds.
roboquat
pushed a commit
that referenced
this pull request
Sep 6, 2022
use the new StopWorkspacePolicy introduced with #12284 to avoid spending resources on backing up discarded prebuilds.
nandajavarma
pushed a commit
that referenced
this pull request
Sep 7, 2022
use the new StopWorkspacePolicy introduced with #12284 to avoid spending resources on backing up discarded prebuilds.
nandajavarma
pushed a commit
that referenced
this pull request
Sep 7, 2022
use the new StopWorkspacePolicy introduced with #12284 to avoid spending resources on backing up discarded prebuilds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows to abort prebuilds that are starting up or running, without incorrectly affecting our success criteria. (it will no longer be treated as failed and we will not attempt to run finalize content on it).
Related Issue(s)
First part of fixing #11453
To completely fix #11453 will require a separate PR from webapp to start using the new policy from this PR.
How to test
Not possible to test until webapp will implement they part as a separate PR
Release Notes
Documentation
Werft options: