Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[usage] Add Go definition for d_b_cost_center #12298

Merged
merged 1 commit into from
Aug 23, 2022
Merged

[usage] Add Go definition for d_b_cost_center #12298

merged 1 commit into from
Aug 23, 2022

Conversation

laushinka
Copy link
Contributor

@laushinka laushinka commented Aug 23, 2022 •
edited

Description

Adds the model for d_b_cost_center in the Usage component.

Related Issue(s)

Relates #12264

How to test

Under /components/usage/pkg/db run go test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@laushinka laushinka changed the title [usage] Cap usage to spendingLimit [usage] Add Go definition for d_b_cost_center Aug 23, 2022
@roboquat roboquat added size/M and removed size/S labels Aug 23, 2022
@laushinka laushinka marked this pull request as ready for review August 23, 2022 09:27
@laushinka laushinka requested a review from a team August 23, 2022 09:27
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Aug 23, 2022
@geropl geropl self-assigned this Aug 23, 2022
geropl
geropl approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tests run: good to go! 🏁

@roboquat roboquat merged commit 1a8512b into main Aug 23, 2022
@roboquat roboquat deleted the lau/cap-usage-12264 branch August 23, 2022 09:38
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees

@geropl geropl

Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@laushinka @geropl @roboquat