Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] Fix golden files #12299

Merged
merged 1 commit into from
Aug 23, 2022
Merged

[installer] Fix golden files #12299

merged 1 commit into from
Aug 23, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 23, 2022

Related Issue(s)

Fixes #11177 (comment)

Release Notes

NONE

Werft options:

  • /werft with-preview

@gitguardian
Copy link

gitguardian bot commented Aug 23, 2022

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
4245826 Generic High Entropy Secret 80e78c3 install/installer/cmd/testdata/render/azure-setup/output.golden View secret
4245827 Generic High Entropy Secret 80e78c3 install/installer/cmd/testdata/render/azure-setup/output.golden View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@mrsimonemms mrsimonemms marked this pull request as draft August 23, 2022 09:29
@mrsimonemms mrsimonemms marked this pull request as ready for review August 23, 2022 09:29
@roboquat roboquat merged commit 5c725a6 into main Aug 23, 2022
@roboquat roboquat deleted the aledbf/golden branch August 23, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants