[usage] Proto changes for GetCostCenter RPC #12337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
approved these changes
Aug 24, 2022
|
|
||
| message CostCenter { | ||
| string attribution_id = 1; | ||
| int32 spending_limit = 2; |
There was a problem hiding this comment.
What's the precision stored in the DB? Is int32 enough? I'd probably err on the side of caution here and go for int64
There was a problem hiding this comment.
It's int(11) which I understand to be 32 bits?
There was a problem hiding this comment.
I worry if we set it to int64 we might truncate something during the conversion?
I will unhold for now to unblock, but we can discuss again what we should store.
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proto changes for the GetCostCenter RPC
Related Issue(s)
Relates #12264
How to test
Release Notes
Documentation
Werft options: