[ws-daemon] when WaitForInit ensure that state is indeed ready #12360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-pavel-12357.1 because the annotations in the pull request description changed |
|
Amazing 🤩 |
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was quite fun to hunt it down.
When calling WaitForInit we will wait for
operatingConditionto broadcast to unlock us.There are two places where broadcast is being done:
MarkInitDonethat changesstatetoWorkspaceReadyDisposethat changesstatetoWorkspaceDisposedIf workspace fails during
InitWorkspace, then its state will be disposed.We call InitWorkspace during
CREATINGphase, and then weWaitForInitinINITIALIZINGstate.So if InitWorkspace failed, we incorrectly would mark workspace as ready, causing all types of issues down the line.
Related Issue(s)
Fixes #12357
Fixes #11713
Fixes #12049
How to test
Release Notes
Documentation
Werft options: