Use previewct get-credentials in werft job
#14091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roboquat
added
do-not-merge/work-in-progress
release-note-none
size/M
size/L
and removed
size/M
labels
vulkoingim
force-pushed
the
aa/use-previewctl-get-creds
branch
from
d950a6b
to
72b840c
Compare
vulkoingim
force-pushed
the
aa/use-previewctl-get-creds
branch
from
b6bc4c3
to
93f2bad
Compare
vulkoingim
changed the title
previewct get-credentials in werft job
mads-hartmann
approved these changes
Oct 24, 2022
There was a problem hiding this comment.
Awesome, looks good to me. I added the hold label just to verify that the the successful job (job 6) was triggered through the CLI rather than a commit - is that the case?
Yeah, it's triggered form the CLI. |
|
Hahah forgot to squash the last commit again 😅
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
previewct get-credentialsto populate a single kubeconfig and target contexts explicitly in tf.Related Issue(s)
Fixes #
How to test
https://werft.gitpod-dev.com/job/gitpod-custom-aa-use-previewctl-get-creds.6/results
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide