Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Display specific Prebuild cancellation reason in Prebuild Status again #14163

Merged
merged 1 commit into from Oct 26, 2022

Conversation

jankeromnes
Copy link
Contributor

Description

When our system decides to cancel a prebuild automatically, it also mentions the specific cancellation reason in prebuild.error:

prebuild.error =
"Prebuild is rate limited. Please contact Gitpod if you believe this happened in error.";

prebuild.error =
"Project is inactive. Please start a new workspace for this project to re-enable prebuilds.";

prebuild.error =
"Repository is inactive. Please create a project for this repository to re-enable prebuilds.";

Also, we used to display this exact message below the Prebuild Logs, so that users could be aware why exactly their prebuild got cancelled:

case "aborted":
return (
<span>
Prebuild has been cancelled. Either a user cancelled it, or the prebuild rate limit has been
exceeded. {props.prebuild.error}
</span>
);

Unfortunately, we recently stopped displaying this reason entirely:

case "aborted":
return `Prebuild has been cancelled. Either a newer commit was pushed to the same branch, a user cancelled it manually, or the prebuild rate limit has been exceeded.`;

I believe this may have been accidental. This Pull Request shows the specific cancellation reason again.

Related Issue(s)

Fixes #

How to test

  1. Get a prebuild cancelled for any reason
  2. Check the cancelled prebuild for why it was cancelled (specific reason should be displayed)

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@jankeromnes jankeromnes requested a review from a team October 25, 2022 15:10
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Oct 25, 2022
@roboquat roboquat merged commit 292a5d6 into main Oct 26, 2022
@roboquat roboquat deleted the jx/show-cancellation-reason branch October 26, 2022 06:53
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants