Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[server] Add counter metric for image build starts #14185

Merged
merged 2 commits into from Oct 26, 2022
Merged

[server] Add counter metric for image build starts #14185

merged 2 commits into from Oct 26, 2022

Conversation

andrew-farries
Copy link
Contributor

@andrew-farries andrew-farries commented Oct 26, 2022 •
edited

Description

Add a metric gitpod_server_image_builds_started_total to count the number of image builds started by server.

Related Issue(s)

Part of #12960

How to test

  • Port-forward to the server metrics port: kubectl port-forward deploy/server 9500:9500
  • Hit the server metrics endpoint at :9500/metrics and look for the gitpod_server_image_builds_started_total metric.
  • Start an image build
  • See the counter increase.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@andrew-farries andrew-farries requested a review from a team October 26, 2022 10:22
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-af-metric-for-server-image-build-starts.7 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Oct 26, 2022
@geropl
Copy link
Member

geropl commented Oct 26, 2022

Starting to review now 🕐

geropl
geropl approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested and works. 🧘

@roboquat roboquat merged commit 1d4de96 into main Oct 26, 2022
@roboquat roboquat deleted the af/metric-for-server-image-build-starts branch October 26, 2022 11:41
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 26, 2022
This was referenced Oct 26, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrew-farries @geropl @roboquat