Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log JSON as strings not an array of bytes #14215

Merged
merged 1 commit into from Oct 26, 2022
Merged

Log JSON as strings not an array of bytes #14215

merged 1 commit into from Oct 26, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Oct 26, 2022

Description

Without an explicit conversion, the log will contain the Base64 representation

How to test

  • Open a workspace
  • Check ws-manager logs and search for the status field. The value should be readable

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@aledbf aledbf requested a review from a team October 26, 2022 21:27
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Oct 26, 2022
kylos101
kylos101 approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@roboquat roboquat merged commit edfd76d into main Oct 26, 2022
@roboquat roboquat deleted the aledbf/logb branch October 26, 2022 21:36
@kylos101 kylos101 mentioned this pull request Oct 27, 2022
Closed
@nandajavarma nandajavarma mentioned this pull request Oct 27, 2022
Merged
4 tasks
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Nov 3, 2022
@adrienthebo adrienthebo removed deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Nov 3, 2022
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Nov 3, 2022
@adrienthebo adrienthebo removed deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Nov 3, 2022
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Nov 3, 2022
@adrienthebo adrienthebo removed deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Nov 3, 2022
@adrienthebo adrienthebo mentioned this pull request Nov 3, 2022
Merged
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylos101 kylos101 kylos101 approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
No open projects
🌌 Workspace Team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aledbf @kylos101 @adrienthebo @roboquat