Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workspacecontexturl to gpcli #16096

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Add workspacecontexturl to gpcli #16096

merged 1 commit into from
Feb 7, 2023

Conversation

Kwok-he-Chu
Copy link
Contributor

@Kwok-he-Chu Kwok-he-Chu commented Jan 30, 2023 •
edited by akosyakov

Description

Added workspaceContextUrl to gp-cli.

I've appended the workspaceContextUrl response from the supervisor API to the gp info command. See #14923

Related Issue(s)

Fixes #14923

How to test

  • Run gitpod in gitpod --> gitpod.io#https://github.com/Kwok-he-Chu/gitpod/tree/add-workspacecontexturl-to-gpicli
  • Run cd components/gitpod-cli
  • Run go run . 'info'
  • Verify whether the WorkspaceContextUrl is shown

Release Notes

Added `Workspace Context Url` to `gp info`

Documentation

The documentation can be found here. From what I see, we do not need to update it. However it would be nice to complete the list. I can forward a documentation request if needed to append the following 5 (+1) variables to the list:

  • Workspace ID
  • Instance ID
  • Workspace class
  • Workspace URL
  • Workspace Context URL // This is the one I added +1
  • Cluster host

If you think it's a good idea, I'll create a docs issue.

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@Kwok-he-Chu Kwok-he-Chu requested a review from a team January 30, 2023 13:14
@werft-gitpod-dev-com
Copy link

annotations in the pull request changed, but user is not allowed to start a job

@Kwok-he-Chu Kwok-he-Chu mentioned this pull request Jan 30, 2023
Closed
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-add-workspacecontexturl-to-gpicli.0 because the annotations in the pull request description changed
(with .werft/ from main)

@akosyakov
Copy link
Member

akosyakov commented Jan 31, 2023 •
edited by werft-gitpod-dev-com bot

/werft run

👍 started the job as gitpod-build-add-workspacecontexturl-to-gpicli-fork.0
(with .werft/ from main)

@Kwok-he-Chu it would be great if you squash to one commit

@gtsiolis do we need CLA here?

gtsiolis
gtsiolis reviewed Jan 31, 2023
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, @Kwok-he-Chu! 🍊

You'll also need to sign a CLA[1] once before merging your first contribution. Cc @meysholdt

Thanks for the ping, @akosyakov! 🏓

@gtsiolis gtsiolis added the do-not-merge/cla-pending CLA has not been signed label Jan 31, 2023
@akosyakov
Copy link
Member

akosyakov commented Feb 1, 2023 •
edited by werft-gitpod-dev-com bot

Build fails, the code is not formatted properly. Could you take about it please? 🙏

@roboquat roboquat added size/L and removed size/S labels Feb 1, 2023
@Kwok-he-Chu
Copy link
Contributor Author

Kwok-he-Chu commented Feb 1, 2023 •
edited

@akosyakov I've synced my fork/upmerged with main and did auto-formatting on the file, could you rerun the job?

Edit: Looking at the formatting changes, it feels like I'm using a different linter that is off to your standards. Could you have a look?

@akosyakov
Copy link
Member

akosyakov commented Feb 1, 2023 •
edited by werft-gitpod-dev-com bot

/werft run

👍 started the job as gitpod-build-add-workspacecontexturl-to-gpicli-fork.1
(with .werft/ from main)

Could you also squash commits into one please? 🙏

@Kwok-he-Chu
Copy link
Contributor Author

Kwok-he-Chu commented Feb 1, 2023 •
edited

Job seems to fail again, let's fix that first. And I'll squash everything into one commit after.

"please gofmt your code" --> Could you have a look? @akosyakov

@Kwok-he-Chu Kwok-he-Chu force-pushed the add-workspacecontexturl-to-gpicli branch from fcae841 to 8f41461 Compare February 1, 2023 12:37
@roboquat roboquat added size/S and removed size/L labels Feb 1, 2023
@Kwok-he-Chu
Copy link
Contributor Author

Kwok-he-Chu commented Feb 1, 2023 •
edited by werft-gitpod-dev-com bot

/werft run

👍 started the job as gitpod-build-add-workspacecontexturl-to-gpicli-fork.1 (with .werft/ from main)

Could you also squash commits into one please? 🙏

Squashed, reformatted again, should be good now 👍

@gtsiolis
Copy link
Contributor

gtsiolis commented Feb 1, 2023 •
edited by werft-gitpod-dev-com bot

/werft run

👍 started the job as gitpod-build-add-workspacecontexturl-to-gpicli-fork.2
(with .werft/ from main)

@Kwok-he-Chu
Copy link
Contributor Author

Kwok-he-Chu commented Feb 1, 2023 •
edited by werft-gitpod-dev-com bot

/werft run

👍 started the job as gitpod-build-add-workspacecontexturl-to-gpicli-fork.2 (with .werft/ from main)

Looks good, what are the next steps?

@gtsiolis
Copy link
Contributor

gtsiolis commented Feb 1, 2023 •
edited

Looks good, what are the next steps?

@Kwok-he-Chu Have you singed the CLA mentioned above?

@Kwok-he-Chu
Copy link
Contributor Author

@gtsiolis Signed yes

@akosyakov
Copy link
Member

akosyakov commented Feb 2, 2023 •
edited by werft-gitpod-dev-com bot

/werft run

👍 started the job as gitpod-build-add-workspacecontexturl-to-gpicli-fork.3
(with .werft/ from main)

akosyakov
akosyakov approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you it works ❤️

@akosyakov
Copy link
Member

akosyakov commented Feb 3, 2023 •
edited by werft-gitpod-dev-com bot

/werft run

👍 started the job as gitpod-build-add-workspacecontexturl-to-gpicli-fork.4
(with .werft/ from main)

@gtsiolis
Copy link
Contributor

gtsiolis commented Feb 7, 2023 •
edited by werft-gitpod-dev-com bot

Removing hold as the CLA has been signed and uploaded to the CLA folder.

Thanks everyone for your patience! 🌮 🌮 🌮 🌮

/unhold

@gtsiolis gtsiolis added cla: accepted ✔️ and removed do-not-merge/cla-pending CLA has not been signed labels Feb 7, 2023
@roboquat roboquat merged commit 64fdd5a into gitpod-io:main Feb 7, 2023
@loujaybee
Copy link
Member

loujaybee commented Feb 7, 2023 •
edited

Thanks @Kwok-he-Chu for the contribution ! 🙏 😍 ✨

@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Feb 7, 2023
@Kwok-he-Chu Kwok-he-Chu deleted the add-workspacecontexturl-to-gpicli branch February 7, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtsiolis gtsiolis gtsiolis left review comments

@akosyakov akosyakov akosyakov approved these changes

Assignees

@Kwok-he-Chu Kwok-he-Chu

Labels
cla: accepted ✔️ community-contribution component: gp cli deployed: IDE IDE change is running in production deployed Change is completely running in production release-note size/S team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detecting which URL was used to spin-up the Gitpod Environment
6 participants
@Kwok-he-Chu @akosyakov @gtsiolis @loujaybee @filiptronicek @roboquat