Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] upgrade code to 1.88.1 #19671

Merged
merged 2 commits into from Apr 29, 2024
Merged

[code] upgrade code to 1.88.1 #19671

merged 2 commits into from Apr 29, 2024

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Apr 25, 2024

Description

Update code to 1.88.1

Progress

How to test

  • Switch to VS Code Browser Insiders in settings.
  • Start a workspace.
  • Test the following:
    • terminals are preserved and resized properly between window reloads
    • WebViews are working
    • extension host process: check language smartness and debugging
    • extension management (installing/uninstalling)
    • install the VIM extension to test web extensions
    • that user data is synced across workspaces as well as on workspace restarts, especially for extensions
      • extensions from .gitpod.yml are not installed as sync
      • extensions installed as sync are actually synced to all new workspaces
    • settings should not contain any mentions of MS telemetry
    • WebSockets and workers are properly proxied
      • diff editor should be operable
      • trigger reconnection with window.WebSocket.disconnectWorkspace(), check that old WebSockets are closed and new opened of the same amount
    • workspace specific commands should work, i.e. F1 → type Gitpod
    • that a PR view is preloaded when opening a PR URL
    • test gp open and gp preview
    • test open in VS Code Desktop, check gp open and gp preview in task/user terminals
    • telemetry data like vscode_extension_gallery is collected in Segment

Preview status

Gitpod was successfully deployed to your preview environment.

Werft options:

  • /werft with-preview
  • /werft analytics=segment
  • /werft with-large-vm

@mustard-mh
Copy link
Contributor Author

hold until upstream released

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock

@mustard-mh
Copy link
Contributor Author

Checked telemetry by update proxy manually

image

@jeanp413
Copy link
Member

@mustard-mh 1.88.1 was released 2 weeks ago https://github.com/microsoft/vscode/releases/tag/1.88.1

@mustard-mh
Copy link
Contributor Author

@mustard-mh 1.88.1 was released 2 weeks ago https://github.com/microsoft/vscode/releases/tag/1.88.1

Oops

@mustard-mh mustard-mh marked this pull request as ready for review April 29, 2024 15:50
@roboquat roboquat merged commit b060c74 into main Apr 29, 2024
14 of 15 checks passed
@roboquat roboquat deleted the hw/vs-188-1 branch April 29, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants