Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] Make Start page re-fetch workspace info after a connection drop #3862

Merged
merged 1 commit into from
Apr 9, 2021
Merged

[dashboard] Make Start page re-fetch workspace info after a connection drop #3862

merged 1 commit into from
Apr 9, 2021

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Apr 9, 2021 •
edited
Loading

Fixes #3811

How to test:

  1. Start a workspace
  2. Turn off WiFi for a bit
  3. Turn Wifi back on
  4. Start page should catch up & not be stuck

Also:

  1. Have a running workspace open
  2. In a separate dashboard tab, click on "Stop" next to your workspace and immediately turn off WiFi
  3. Return to the workspace tab (should show the IDE or Stopping...)
  4. After a while, turn WiFi back on
  5. Workspace tab should now show "Stopped" (and not the IDE, or "Stopping...", or "Starting...")

@jankeromnes jankeromnes marked this pull request as ready for review April 9, 2021 08:20
@AlexTugarev
Copy link
Member

AlexTugarev commented Apr 9, 2021 •
edited
Loading

code looks good. testing now...

it took a while for the websocket to reconnect, but that's just because the reconnecting behavior is configured that way.

AlexTugarev
AlexTugarev approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely! Thanks!

@jankeromnes jankeromnes merged commit d0af3f4 into main Apr 9, 2021
@jankeromnes jankeromnes deleted the jx/refetch-ws-info branch April 9, 2021 11:47
@jankeromnes jankeromnes mentioned this pull request May 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexTugarev AlexTugarev AlexTugarev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[dashboard] Sometimes, the "Stopped / Timed Out" screen shows "Starting / Opening IDE ..." instead
2 participants
@jankeromnes @AlexTugarev