Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Improve error message when trying to open a PR with deleted branch #3869

Merged
merged 2 commits into from
Apr 12, 2021

Conversation

jankeromnes
Copy link
Contributor

Fixes #4 #321 #802 #1375 #3659 gitpod-com/gitpod#1722 gitpod-com/gitpod#2244

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Apr 9, 2021

@jankeromnes jankeromnes marked this pull request as ready for review April 9, 2021 13:14
@jankeromnes
Copy link
Contributor Author

Currently looks like this:

Screenshot 2021-04-09 at 15 17 19

@csweichel
Copy link
Contributor

csweichel commented Apr 12, 2021

/werft run

👍 started the job as gitpod-build-jx-fix-4.3

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the oldest issue (#4) for this repository and locating all the duplicate issues for this @jankeromnes! 🎖️

Fixes #4 #321 #802 #1375 #3659 gitpod-com/gitpod#1722 gitpod-com/gitpod#2244

🤯

components/server/src/github/github-context-parser.ts Outdated Show resolved Hide resolved
@@ -96,5 +96,5 @@ function StartError(props: { error: StartWorkspaceError }) {
if (!error) {
return null;
}
return <p className="text-base text-gitpod-red">{error.message}</p>;
return <p className="text-base text-gitpod-red w-96">{error.message}</p>;
Copy link
Contributor

@gtsiolis gtsiolis Apr 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Go w-96! 🔮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle old PRs with deleted branches.
3 participants