Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[whats-new] update ideSettings if not set before #3914

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Conversation

AlexTugarev
Copy link
Member

what's new / ideSettings

if additionalData was empty before, it should now end up with populated ideSettings after checking the what's new modal.

@AlexTugarev
Copy link
Member Author

AlexTugarev commented Apr 19, 2021

/werft run

👍 started the job as gitpod-build-at-whats-new.1

@jankeromnes
Copy link
Contributor

jankeromnes commented Apr 22, 2021

Taking a look at this now. 👀

@jankeromnes
Copy link
Contributor

jankeromnes commented Apr 22, 2021

/werft run

👍 started the job as gitpod-build-at-whats-new.3

Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good to me (🧙‍♂️) and works as advertised.

Thanks! Approved. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants