Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Improve handling of errors and cache headers #3935

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 14, 2021

fixes #3818

@aledbf
Copy link
Member Author

aledbf commented Apr 14, 2021

A request to non-existing resources returns 404 and no-cache headers

curl https://aledbf-caddy404.staging.gitpod-dev.com/static/js/8.58a8dbda.chunk.js1 -vvv
*   Trying 34.76.116.244:443...
> GET /static/js/8.58a8dbda.chunk.js1 HTTP/1.1
> Host: aledbf-caddy404.staging.gitpod-dev.com
> User-Agent: curl/7.68.0
> Accept: */*
> 
* Mark bundle as not supporting multiuse
< HTTP/1.1 404 Not Found
< Date: Wed, 14 Apr 2021 17:51:05 GMT
< Content-Length: 0
< Connection: keep-alive
< X-Gitpod-Region: devstaging.gitpod-core.europe-west1.00
< Access-Control-Allow-Origin: https://aledbf-caddy404.staging.gitpod-dev.com
< Access-Control-Allow-Credentials: true
< Access-Control-Expose-Headers: Authorization
< 
* Connection #0 to host aledbf-caddy404.staging.gitpod-dev.com left intact

@aledbf aledbf force-pushed the aledbf/caddy404 branch 5 times, most recently from 8341090 to 82552fd Compare April 14, 2021 17:42
@aledbf aledbf requested review from akosyakov and geropl April 14, 2021 22:28
@aledbf aledbf marked this pull request as ready for review April 14, 2021 22:28
@aledbf aledbf requested a review from csweichel April 15, 2021 13:30
@akosyakov
Copy link
Member

akosyakov commented Apr 16, 2021

/werft run

👍 started the job as gitpod-build-aledbf-caddy404.14

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked well for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proxy] Make sure we do not (long-term) cache error responses
2 participants