updgrade to VS Code 1.55.x

[akosyakov]

What it does

• fix updgrade to VS Code 1.55.x #3694: updgrade to VS Code 1.55.x
• fix [vscode] terminals resizing issues on reload #3553: see [vscode] terminals resizing issues on reload #3553 (comment)

Changes in Gitpod Code: gitpod-io/openvscode-server@cbe1690

How to test

• websockets and workers are properly proxied
  • diff editor should be operatable
  • trigger reconnection with window.WebSocket.disconnectWorkspace(), check that old websockets are closed and new opened of the same amount, it can take around 30s
• that user data are sync across workspaces as well as on workspace restart, especially for extensions
  • test that extensions from .gitpod.yml are installed without sync
  • ignore CORS issues in logs, they are not matter
• terminals are preserved and resized properly between window reloads
• workspace specific commands should work, i.e. F1 → type Gitpod prefix
• that a PR view is preloaded on the PR url, make sure that you grant process scopes for GitHub installation, namely: user: read and repo
• test gp open and preview

[akosyakov]

Webview are broken:

resourceLoader.ts:169 Error: Unable to read file 'vscode-remote://amaranth-crane-ek2ss7ec.ws-dev.akosyakov-updgrade-to-vs-code-x-3694.staging.gitpod-dev.com:443/vscode-resource?{"requestResourcePath":"/ide/extensions/simple-browser/media/codicon.css"}' (Error: Unable to resolve non-existing file 'vscode-remote://amaranth-crane-ek2ss7ec.ws-dev.akosyakov-updgrade-to-vs-code-x-3694.staging.gitpod-dev.com:443/vscode-resource?{"requestResourcePath":"/ide/extensions/simple-browser/media/codicon.css"}')
    at FileService.doReadFileStream (fileService.ts:525)
    at async readFileStream (resourceLoader.ts:75)
    at async loadLocalResource (resourceLoader.ts:153)
    at async IFrameWebview.loadResource (webviewElement.ts:206)

[akosyakov]

It should be good now.

[csweichel]

/werft run

👍 started the job as gitpod-build-akosyakov-updgrade-to-vs-code-x-3694.7

[csweichel]

• websockets and workers are properly proxied
  • ✅ diff editor should be operatable
  • ⚠️ trigger reconnection with window.WebSocket.disconnectWorkspace(), check that old websockets are closed and new opened of the same amount ; running window.WebSocket.disconnectWorkspace() had no discerneble effect
• that user data are sync across workspaces as well as on workspace restart, especially for extensions
  • ⚠️ test that extensions from .gitpod.yml are installed without sync: could not test due to open-vsx issues
• ✅ terminals are preserved and resized properly between window reloads
• ✅ workspace specific commands should work, i.e. F1 → type Gitpod prefix
• ❌ that a PR view is preloaded on the PR url: I tried to open updgrade to VS Code 1.55.x #3937 as context URL and no PR view was shown
• ✅ test gp open and preview

[akosyakov]

trigger reconnection with window.WebSocket.disconnectWorkspace(), check that old websockets are closed and new opened of the same amount ; running window.WebSocket.disconnectWorkspace() had no discerneble effect

It can take a while, like 30 seconds before disconnect is detected, see below triggered at 23:12, reconnected at 23:32

test that extensions from .gitpod.yml are installed without sync: could not test due to open-vsx issues

If it is about CORS errors in devtools, you can ignore them. Most important that search and install from user perspective should work.

that a PR view is preloaded on the PR url: I tried to open #3937 as context URL and no PR view was shown

Please make sure that you granted proper permissions, namely: user: read and repo, otherwise you should see:

[akosyakov]

@csweichel I pushed a fix for preloading the PR view. Good catch!

[akosyakov]

/werft run

👍 started the job as gitpod-build-akosyakov-updgrade-to-vs-code-x-3694.9

[csweichel]

Works after signing in