[server] Implement a getAllEnvVars() method that doesn't filter on repository pattern precedence #3938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankeromnes
force-pushed
the
jx/fix-env-vars
branch
from
6fc00fd
to
c9f6e98
Compare
…r on repository pattern precedence
jankeromnes
force-pushed
the
jx/fix-env-vars
branch
from
c9f6e98
to
9a8121b
Compare
jankeromnes
changed the title
|
Ok, this now works as expected again. Please take a look. 😇 |
|
Looking at this now! 👀 |
gtsiolis
approved these changes
Apr 14, 2021
There was a problem hiding this comment.
Thank you for fixing this @jankeromnes!
question: Is it expected that using the same variable name and project scope does not work? If so, could we add a validation error message telling the user that this variable name for this scope alrady exists? Feel free to open a follow up issue for this. 🏓
|
Many thanks for the quick review! 💯
Whoops, indeed. Done: #3942 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3839
Context: The repository pattern precedence filtering was hoisted from theia into server in #3569, but it's not actually relevant to show users all their environment variables.