Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Fix the 'addComment' and 'addBadge' prebuild features in the Gitpod GitHub App #4043

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Apr 22, 2021

This PR fixes Gitpod's addComment and addBadge prebuild features by updating our GitHub App code to the latest Probot/Octokit API.

It also fixes:

ERROR    (event): Cannot read property 'update' of undefined
    TypeError: Cannot read property 'update' of undefined
        at GithubApp.onPrAddBadge (/app/node_modules/@gitpod/server/dist/ee/src/prebuilds/github-app.js:241:57)
        at GithubApp.<anonymous> (/app/node_modules/@gitpod/server/dist/ee/src/prebuilds/github-app.js:171:22)
        at Generator.next (<anonymous>)
        at fulfilled (/app/node_modules/@gitpod/server/dist/ee/src/prebuilds/github-app.js:22:58)
        at runMicrotasks (<anonymous>)
        at processTicksAndRejections (internal/process/task_queues.js:97:5)

and:

WARN     (event): [probot] "context.github" is deprecated. Use "context.octokit" instead.

How to test:

  • Open PRs against any repository configured with the gitpod-staging GitHub App, for example https://github.com/jankeromnes/gitpod-staging-prebuilds
  • The PR should receive a "badge" (button in the PR comment), a comment with a button, and a PR check. All buttons should work, have a non-broken image, and open the PR in Gitpod
  • The server shouldn't log errors related to GithubApp

@jankeromnes jankeromnes force-pushed the jx/fix-github-app branch 3 times, most recently from 3998b1c to 943d290 Compare April 22, 2021 19:05
@jankeromnes
Copy link
Contributor Author

jankeromnes commented Apr 22, 2021

@jankeromnes
Copy link
Contributor Author

Screenshot 2021-04-23 at 09 06 17

@jankeromnes jankeromnes added this to the April 2021 milestone Apr 23, 2021
@jankeromnes jankeromnes changed the title [server] Fix TypeError: Cannot read property 'update' of undefined in GithubApp.onPrAddBadge [server] Fix the 'addComment' and 'addBadge' prebuild features in the Gitpod GitHub App Apr 23, 2021
@jankeromnes jankeromnes added the changelog worth adding to www.gitpod.io/changelog label Apr 23, 2021
@jankeromnes jankeromnes requested review from csweichel and removed request for csweichel April 23, 2021 08:57
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as advertised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog worth adding to www.gitpod.io/changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants