[github] fix register app #4093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexTugarev
commented
Apr 28, 2021
| pathname: '/authorize', | ||
| search: `returnTo=${returnTo}&host=github.com&scopes=repo` | ||
| }).toString(); | ||
| window.open(url, "gitpod-login"); |
There was a problem hiding this comment.
this is left-over. the window.open call is centralized in openAuthorizeWindow.
jankeromnes
approved these changes
Apr 28, 2021
| @@ -16,13 +16,6 @@ async function registerApp(installationId: string, setModal: (modal: 'done' | st | |||
| try { | |||
| await getGitpodService().server.registerGithubApp(installationId); | |||
There was a problem hiding this comment.
Thought: If possible, every window.open() call should always happen in the exact same event loop cycle as the click event.
Otherwise the window.open() will most likely be blocked by the browser's pop-up blocker. This means, no await, no callbacks, etc.
There was a problem hiding this comment.
Can we change the order?
AlexTugarev
force-pushed
the
at/clean-up
branch
from
c422aaa
to
6ff039b
Compare
AlexTugarev
commented
Apr 28, 2021
| @@ -56,12 +56,8 @@ async function openAuthorizeWindow(params: OpenAuthorizeWindowParams) { | |||
| search: `returnTo=${encodeURIComponent(returnTo)}&host=${host}&override=true&scopes=${(scopes || []).join(',')}` | |||
| }).toString(); | |||
|
|
|||
| const newWindow = window.open(url, "gitpod-auth-window"); | |||
| if (!newWindow) { | |||
There was a problem hiding this comment.
reverting this to get to square one, where the untracked new window was opened just fine.
let's think this through one more time, next time 🙏🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4092