Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] fix repo forking #4098

Merged
merged 1 commit into from
Apr 28, 2021
Merged

[code] fix repo forking #4098

merged 1 commit into from
Apr 28, 2021

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Apr 28, 2021

What it does

  • It reverts some Codespaces specific changes in VS Code to fix parsing of remote urls.

Changes in Gitpod Code: gitpod-io/openvscode-server@e01c9d7

How to test

  • Start a workspace for some repo for which you don't have a fork yet, like: https://github.com/philskat/js-sort
  • Create a commit and then try to push.
  • You should get different notifications about missing permissions and suggestion to fork.
  • Go to access control and grant missing permissions and then press fork.
  • You should get a fork, and your workspace should be reconfigured to use new remote.

Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised, thanks!

Screenshot 2021-04-28 at 20 09 51

Screenshot 2021-04-28 at 20 10 50

It adjusted the remotes, but also showed another warning (not sure if important):

Screenshot 2021-04-28 at 20 13 15

@akosyakov akosyakov merged commit 477d7f8 into main Apr 28, 2021
@akosyakov akosyakov deleted the ak/fix_fork branch April 28, 2021 18:23
@jankeromnes
Copy link
Contributor

jankeromnes commented Apr 28, 2021

(Ah, maybe the warning was because I deleted the fork 😅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants