Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] upgrade to version 1.56.2 #4257

Merged
merged 5 commits into from
May 21, 2021
Merged

[code] upgrade to version 1.56.2 #4257

merged 5 commits into from
May 21, 2021

Conversation

JanKoehnlein
Copy link
Contributor

@akosyakov
Copy link
Member

akosyakov commented May 20, 2021

terminal tabs does not seem to work
Screenshot 2021-05-20 at 11 22 34

It seems to be because we don't provide icons. We should check how icons are created for local VS Code and do the same.
Relevant PR in upstream: microsoft/vscode#120878

for info: https://code.visualstudio.com/updates/v1_56#_terminal-tabs

@akosyakov
Copy link
Member

akosyakov commented May 21, 2021

/werft run

👍 started the job as gitpod-build-jk-vscode-1.56.2.6

@akosyakov akosyakov marked this pull request as ready for review May 21, 2021 11:37
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JanKoehnlein JanKoehnlein merged commit 8ade31b into main May 21, 2021
@JanKoehnlein JanKoehnlein deleted the jk/vscode-1.56.2 branch May 21, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants