Use new OAuth endpoint for login #4267
Conversation
| // Login walks through the login flow for obtaining a Gitpod token | ||
| func Login(ctx context.Context, opts LoginOpts) (token string, err error) { | ||
| rl, err := net.Listen("tcp", "localhost:0") | ||
| rl, err := net.Listen("tcp", "localhost:64110") |
There was a problem hiding this comment.
I reckon the "use unused port" way is less error prone - or am I missing a reason to hardcode this?
There was a problem hiding this comment.
I agree, but yes, (unfortunately) the redirect URL has to be known to the backend.
There was a problem hiding this comment.
Could it be configurable if the port is already used?
There was a problem hiding this comment.
No, not yet at least. The backend validates the full redirect uri, including port, so it would need a way to override that behaviour (which might be worth PR-ing on the lib).
In the interim I've changed it, along with the backend, to try a range of 10 ports and be more explicit about using IPV4 to workaround issues with IPV6 I saw while testing.
rl-gitpod
force-pushed
the
rl/local-app-oauth
branch
4 times, most recently
from
c33c7ca
to
3ffccb8
Compare
| port := STARTING_PORT_NUM | ||
| for port < ENDING_PORT_NUM { |
There was a problem hiding this comment.
A more classic for loop would be easier to understand here I reckon (no searching for port++).
Remove testing code Use correct scope for all workspaces Clean up logging + error behaviour Use tcp4 and 127.0.0.1 to avoid IPV6 issues
rl-gitpod
force-pushed
the
rl/local-app-oauth
branch
from
3ffccb8
to
882be00
Compare
|
/werft run 👍 started the job as gitpod-build-rl-local-app-oauth.7 |
Remove testing code
Use correct scope for all workspaces
Clean up logging + error behaviour