Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing secondary class from the main CTA button to give proper weight. #4288

Merged

Conversation

jordanhailey
Copy link
Contributor

Per #4197, same code as #4286 with shorter branch name to avoid build error.

@gtsiolis
Copy link
Contributor

gtsiolis commented May 24, 2021

Thanks for reopening this @jordanhailey! Let's run this! 🏃

/werft run

👍 started the job as gitpod-build-jordanhailey-issue-4197-fork.0

@jordanhailey
Copy link
Contributor Author

By toggling the css classes on the browser I was able to confirm the secondary class is the "muted" color, it is a grey background with darker grey text. By removing that class in the browser I could test that the default styles applied on buttons are the green background and white text as pictured in the comment at #4197 (comment)

NOTE: I couldn't actually verify the change was applied to the button on the "not authorized" screen due to the restrictions placed on the dev environments, not being able to add a workspace. Instead, when trying to add a workspace I ended up receiving the following message:

Your account has been blocked.
Please contact support if you think this is an error. See also terms of service.

@jordanhailey jordanhailey marked this pull request as ready for review May 24, 2021 22:05
@JanKoehnlein JanKoehnlein added this to the [backlog] June 2021 milestone Jun 1, 2021
Copy link
Contributor

@corneliusludmann corneliusludmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for your contribution! 🚀

Fixes #4197.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants