Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues blocking ssh from local terminal #4358

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Fix issues blocking ssh from local terminal #4358

merged 1 commit into from
Jun 2, 2021

Conversation

rl-gitpod
Copy link
Contributor

Deleted 'defer'ed close of terminal was main cause.

Fixed some other minor issues while there.

@rl-gitpod
Don't close terminal immediately
1aaf5c5 
Allow longer terminal timeout

Default host to gitpod.io - closes #4347
Save token to keyring - closes #4346
Strip off trailing slash on host
aledbf
aledbf approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@aledbf aledbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rl-gitpod rl-gitpod merged commit 898b629 into main Jun 2, 2021
@rl-gitpod rl-gitpod deleted the rl/local-app-ssh-no-tunnel branch June 2, 2021 00:07
jankeromnes pushed a commit that referenced this pull request Jun 3, 2021
@rl-gitpod @jankeromnes
Don't close terminal immediately (#4358)
638d0f8 
[local-app] Fix direct SSH failure

Allow longer terminal timeout
Default host to gitpod.io - closes #4347
Save token to keyring - closes #4346
Strip off trailing slash on host
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledbf aledbf aledbf approved these changes

@csweichel csweichel Awaiting requested review from csweichel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rl-gitpod @aledbf