Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] on 404 redirect to www #4364

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Jun 1, 2021

@svenefftinge svenefftinge changed the title [dashboard] on 404 redirect to www [WIP][dashboard] on 404 redirect to www Jun 1, 2021
@svenefftinge svenefftinge force-pushed the dashboard_404_redirect branch 3 times, most recently from 374dd8e to d765747 Compare June 1, 2021 11:53
@svenefftinge
Copy link
Member Author

svenefftinge commented Jun 2, 2021

/werft run

👍 started the job as gitpod-build-dashboard-404-redirect.4

@svenefftinge svenefftinge changed the title [WIP][dashboard] on 404 redirect to www [dashboard] on 404 redirect to www Jun 2, 2021
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! ✔️

Two questions:

  1. There's a small redirection delay where we print a label (www.gitpod.io). Expected? Would it make sense to rephrase this to Redirecting ... or remove it? Works fine as is, too.
  2. Also, is this going to work ok when we introduce teams and users can create for example a docs team with a URL like gitpod.io/docs?
Untitled.mov

@svenefftinge
Copy link
Member Author

Also, is this going to work ok when we introduce teams and users can create for example a docs team with a URL like gitpod.io/docs

We need to whitelist all the slugs that we disallow for teams and that would include the slugs from the website.

@svenefftinge svenefftinge merged commit 45f2d92 into main Jun 4, 2021
@svenefftinge svenefftinge deleted the dashboard_404_redirect branch June 4, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants