[cli] replace pstree in credential helper #4385
Conversation
|
/werft run |
|
/werft run 👍 started the job as gitpod-build-jk-gitpod-extension-warning-4062.1 |
JanKoehnlein
force-pushed
the
jk-gitpod-extension-warning-4062
branch
from
2824282
to
ffe8f20
Compare
|
/werft run 👍 started the job as gitpod-build-jk-gitpod-extension-warning-4062.4 |
There was a problem hiding this comment.
Quickly checked with the repo from GH issue and it works as advertised!
The remote repository "https://github.com/icub-tech-iit/documentation.git" is not accessible with the current token. Please grant the necessary permissions.
|
@JanKoehnlein Is it still work in process? Asking due to the |
JanKoehnlein
changed the title
|
Changed the title to reflect that this is ready for review |
| func logDebug(v ...interface{}) { | ||
| if os.Getenv("CREDENTIAL_HELPER_DEBUG_LOG") == "true" { | ||
| log.Println(v...) | ||
| func parseProcessTree() (repoUrl string, gitCommand string) { |
There was a problem hiding this comment.
Any chance we could write some unit tests for this? Not just for the actual test but that would also help to understand the function because we would have a list of some example inputs and expected outputs.
Sure, the problem here is to mock the readProc function for the test, right? Any ideas?
|
The crucial part is to interpret/parse what comes out of |
Fixes #4062