[ws-manager] Backup on pod eviction #4405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csweichel
force-pushed
the
cw/backup-on-eviction
branch
from
c98f0bb
to
18b3256
Compare
jankeromnes
reviewed
Jun 7, 2021
CHANGELOG.md
Outdated
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| All notable changes to this project will be documented in this file. | |||
|
|
|||
| ## July 2021 | |||
|
|
|||
| - Improve backup stability when pods get evicted ([#4405](https://github.com/gitpod-io/gitpod/pull/4405)) | |||
There was a problem hiding this comment.
Nit: I think we're still in the June cycle. 😇
|
Many thanks for the quick fix! If possible, it would be cool to have quick "how to test" instructions, in order to confirm that backups still work in both cases:
|
|
Test instructions:
See also #4415 |
corneliusludmann
approved these changes
Jun 8, 2021
Co-authored-by: Cornelius A. Ludmann <cornelius.ludmann@typefox.io>
JanKoehnlein
added a commit
that referenced
this pull request
Jun 9, 2021
* [ws-manager] Backup on pod eviction * Fixed changelog * Update components/ws-manager/pkg/manager/monitor.go Co-authored-by: Cornelius A. Ludmann <cornelius.ludmann@typefox.io> Co-authored-by: Jan Koehnlein <jan@gitpod.io> Co-authored-by: Cornelius A. Ludmann <cornelius.ludmann@typefox.io>
csweichel
added a commit
that referenced
this pull request
Jun 23, 2021
csweichel
added a commit
that referenced
this pull request
Jun 25, 2021
MatthewFagan
pushed a commit
to trilogy-group/gitpod
that referenced
this pull request
Nov 23, 2021
* [ws-manager] Backup on pod eviction * Fixed changelog * Update components/ws-manager/pkg/manager/monitor.go Co-authored-by: Cornelius A. Ludmann <cornelius.ludmann@typefox.io> Co-authored-by: Jan Koehnlein <jan@gitpod.io> Co-authored-by: Cornelius A. Ludmann <cornelius.ludmann@typefox.io>
MatthewFagan
pushed a commit
to trilogy-group/gitpod
that referenced
this pull request
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stores the hostIP as annotation s.t. in case of eviction we know which ws-daemon to talk to. When pods get evicted they loose their association with the node they ran on, which until now broke backups.