-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ws-manager] Backup on pod eviction #4405
Conversation
c98f0bb
to
18b3256
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CHANGELOG.md
Outdated
@@ -2,6 +2,10 @@ | |||
|
|||
All notable changes to this project will be documented in this file. | |||
|
|||
## July 2021 | |||
|
|||
- Improve backup stability when pods get evicted ([#4405](https://github.com/gitpod-io/gitpod/pull/4405)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I think we're still in the June cycle. 😇
Many thanks for the quick fix! If possible, it would be cool to have quick "how to test" instructions, in order to confirm that backups still work in both cases:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test instructions:
See also #4415 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small NIT (misleading log message).
Everything else looks fine! 👍
Co-authored-by: Cornelius A. Ludmann <cornelius.ludmann@typefox.io>
* [ws-manager] Backup on pod eviction * Fixed changelog * Update components/ws-manager/pkg/manager/monitor.go Co-authored-by: Cornelius A. Ludmann <cornelius.ludmann@typefox.io> Co-authored-by: Jan Koehnlein <jan@gitpod.io> Co-authored-by: Cornelius A. Ludmann <cornelius.ludmann@typefox.io>
* [ws-manager] Backup on pod eviction * Fixed changelog * Update components/ws-manager/pkg/manager/monitor.go Co-authored-by: Cornelius A. Ludmann <cornelius.ludmann@typefox.io> Co-authored-by: Jan Koehnlein <jan@gitpod.io> Co-authored-by: Cornelius A. Ludmann <cornelius.ludmann@typefox.io>
This PR stores the hostIP as annotation s.t. in case of eviction we know which ws-daemon to talk to. When pods get evicted they loose their association with the node they ran on, which until now broke backups.