[dashboard] Harmonize confirmation dialog #4408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanKoehnlein
approved these changes
Jun 7, 2021
corneliusludmann
force-pushed
the
corneliusludmann/dashboard-dark-4264
branch
from
5b6ee0a
to
a7a1674
Compare
corneliusludmann
force-pushed
the
corneliusludmann/dashboard-dark-4264
branch
from
a7a1674
to
463148a
Compare
This was referenced Jun 8, 2021
|
Thanks @corneliusludmann for fixing and @JanKoehnlein for reviewing this! |
gtsiolis
reviewed
Jun 8, 2021
|
|
||
| export default function ConfirmationModal(props: { | ||
| title?: string; | ||
| areYouSureText?: string, |
There was a problem hiding this comment.
praise: Nice one! Thanks for adding this abstraction based on the existing modals. 🔝
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are confirmation dialogs on different places where the code has be copied. In some cases, small deviations have been introduced unintentionally (slightly different shade of gray, etc.). For this reason, this PR introduces a common
ConfirmationModal.This fixes also #4264, and #3701.
/cc @gtsiolis