[code] upgrade to VS Code 1.57.0

[akosyakov]

What it does

• fix upgrade to VS Code 1.57.x #4403
• fix [code] icons of terminals are not preserved on reload #4268
• fix Weird font in terminal #4130

Changes in Gitpod Code: gitpod-io/openvscode-server@bcd47c1

How to test

• Start a workspace: https://ak-vscode-update.staging.gitpod-dev.com/#https://github.com/gitpod-io/gitpod
• • websockets and workers are properly proxied
    • diff editor should be operatable
    • trigger reconnection with window.WebSocket.disconnectWorkspace(), check that old websockets are closed and new opened of the same amount
• that user data are sync across workspaces as well as on workspace restart, especially for extensions
  • test that extensions from .gitpod.yml are installed without sync
• terminals are preserved and resized properly between window reloads
  • try to rename, change color and icon of a terminal. It should be preserved on page reload as well.
• workspace specific commands should work, i.e. F1 → type Gitpod prefix
• that a PR view is preloaded on the PR url
• test gp open and preview
• smoke test on Chrome, FF, and Safari on Mac/iPad

[codecov]

Codecov Report

Merging #4507 (d84dc77) into main (eaa6e80) will decrease coverage by 6.73%.
The diff coverage is 35.93%.

@@            Coverage Diff             @@
##             main    #4507      +/-   ##
==========================================
- Coverage   38.39%   31.65%   -6.74%     
==========================================
  Files          37       29       -8     
  Lines        5915     4792    -1123     
==========================================
- Hits         2271     1517     -754     
+ Misses       3469     3156     -313     
+ Partials      175      119      -56     

Flag	Coverage Δ
components-gitpod-cli-app	13.33% <ø> (ø)
components-local-app-app-darwin	∅ <ø> (∅)
components-local-app-app-linux	∅ <ø> (∅)
components-local-app-app-windows	∅ <ø> (∅)
components-supervisor-app	36.61% <35.93%> (-0.03%)	⬇️
components-ws-proxy-app	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/supervisor/pkg/terminal/service.go	29.09% <11.11%> (-2.16%)	⬇️
components/supervisor/pkg/terminal/terminal.go	64.50% <54.05%> (-0.58%)	⬇️
components/supervisor/pkg/ports/ports.go	61.16% <0.00%> (-0.19%)	⬇️
components/ws-proxy/pkg/proxy/config.go
components/ws-proxy/pkg/proxy/routes.go
components/ws-proxy/pkg/proxy/proxy.go
components/ws-proxy/pkg/proxy/cookies.go
components/ws-proxy/pkg/proxy/workspacerouter.go
components/ws-proxy/pkg/proxy/pass.go
components/ws-proxy/pkg/proxy/infoprovider.go
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaa6e80...d84dc77. Read the comment docs.

[JanKoehnlein]

When I change the icon of a terminal, the IDE stalls (websocket disconnects and fails to reconnect), even for other tabs on the same workspace.

Log says

2021-06-16 13:34:23.003 GMTpanic: assignment to entry in nil map goroutine 387 [running]: github.com/gitpod-io/gitpod/supervisor/pkg/terminal.(*Term).UpdateAnnotations(0xc000129560, 0xc0004547b0, 0xc0004391e0, 0x1, 0x1) github.com/gitpod-io/gitpod/supervisor/pkg/terminal/terminal.go:318 +0x127 github.com/gitpod-io/gitpod/supervisor/pkg/terminal.(*MuxTerminalService).UpdateAnnotations(0xc000011ef0, 0xf01890, 0xc000454900, 0xc000b14c00, 0xc000011ef0, 0x0, 0x0) github.com/gitpod-io/gitpod/supervisor/pkg/terminal/service.go:354 +0xd1 github.com/gitpod-io/gitpod/supervisor/api._TerminalService_UpdateAnnotations_Handler.func1(0xf01890, 0xc000454900, 0xd5b580, 0xc000b14c00, 0x2d, 0xc02a9d57bb6e9dfc, 0x63659b477, 0x13e88c0) github.com/gitpod-io/gitpod/supervisor/api@v0.0.0-00010101000000-000000000000/terminal_grpc.pb.go:388 +0x89 github.com/grpc-ecosystem/go-grpc-middleware/logging/logrus.UnaryServerInterceptor.func1(0xf01890, 0xc000875ec0, 0xd5b580, 0xc000b14c00, 0xc000450e00, 0xc0003a1e60, 0xc0007d8ba0, 0x4a2766, 0xd658e0, 0xc000875ec0) github.com/grpc-ecosystem/go-grpc-middleware@v1.3.0/logging/logrus/server_interceptors.go:31 +0x12f github.com/gitpod-io/gitpod/supervisor/api._TerminalService_UpdateAnnotations_Handler(0xd89f00, 0xc000011ef0, 0xf01890, 0xc000875ec0, 0xc000b14ba0, 0xc0004fe030, 0xf01890, 0xc000875ec0, 0xc0002c6100, 0x73) github.com/gitpod-io/gitpod/supervisor/api@v0.0.0-00010101000000-000000000000/terminal_grpc.pb.go:390 +0x150 google.golang.org/grpc.(*Server).processUnaryRPC(0xc0002361c0, 0xf09158, 0xc00013d080, 0xc000a60480, 0xc0004e8660, 0x13d6968, 0x0, 0x0, 0x0) google.golang.org/grpc@v1.38.0/server.go:1286 +0x52b google.golang.org/grpc.(*Server).handleStream(0xc0002361c0, 0xf09158, 0xc00013d080, 0xc000a60480, 0x0) google.golang.org/grpc@v1.38.0/server.go:1609 +0xd0c google.golang.org/grpc.(*Server).serveStreams.func1.2(0xc0004e6190, 0xc0002361c0, 0xf09158, 0xc00013d080, 0xc000a60480) google.golang.org/grpc@v1.38.0/server.go:934 +0xab created by google.golang.org/grpc.(*Server).serveStreams.func1 google.golang.org/grpc@v1.38.0/server.go:932 +0x1fd

[akosyakov]

@JanKoehnlein please try again

[JanKoehnlein]

Thanks a lot, @akosyakov. LGTM now.

Nit: Changing the icon of a terminal is not reflected in other tabs on the same workspace while rename is.

I'd love to see @corneliusludmann test as well, as this has big impact.

[akosyakov]

Changing the icon of a terminal is not reflected in other tabs on the same workspace while rename is.

It is limitations of terminal channel protocol. There is an event for changed title, but not an event for changed icon/color.

[corneliusludmann]

When I execute gp open test, a new workspace tab opens:

• This happens when the file does not exist. For existing files opening with gp open works.
• In the past, gp open (resp. open) worked for not-existing files as well. I used it a lot for creating a new file.

Peek.2021-06-17.12-54.mp4

[corneliusludmann]

Everything else looks good.

[akosyakov]

@corneliusludmann gp open is code cli now, ant it has own semantic, I guess you have test folder and it opens this folder in a new tab

[corneliusludmann]

@corneliusludmann gp open is code cli now, ant it has own semantic, I guess you have test folder and it opens this folder in a new tab

You're right! My fault.