Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gitpod.yml] Remove deprecated openModes split-top and split-bottom #4524

Merged
merged 1 commit into from
Jun 16, 2021
Merged

[gitpod.yml] Remove deprecated openModes split-top and split-bottom #4524

merged 1 commit into from
Jun 16, 2021

Conversation

corneliusludmann
Copy link
Contributor

@corneliusludmann corneliusludmann commented Jun 16, 2021 •
edited
Loading

The openModes split-top and split-bottom are deprecated because VSCode does not support them. See also https://www.gitpod.io/docs/references/gitpod-yml#tasksnopenmode.

Fixes #4340

JanKoehnlein
JanKoehnlein approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corneliusludmann corneliusludmann merged commit 1ce7a0b into main Jun 16, 2021
@corneliusludmann corneliusludmann deleted the corneliusludmann/deprecate-unsupported-4340 branch June 16, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanKoehnlein JanKoehnlein JanKoehnlein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate unsupported openModes
2 participants
@corneliusludmann @JanKoehnlein