[dashboard] Refactor What's New dialog #4607

corneliusludmann · 2021-06-24T15:43:44Z

That's how it looks like for an active user that has already VSCode as editor:

Light Theme	Dark Theme

That's how it looks like for an active user that still has Theia as editor:

Light Theme	Dark Theme

After the click on “Close” or “X” the editor will be changed to VSCode. The user has to change this back in the preferences.

That's how it looks like for a user that has not been seen the previous “What's New” message because he/she has not logged in since then.

Light Theme	Dark Theme

Fixes #4459

See also: #3956

gtsiolis

Thanks for adding this, @corneliusludmann! 🎁

Left some early feedback in the relevant discussion (internal).

components/dashboard/src/whatsnew/WhatsNew-2021-06.tsx

components/dashboard/src/whatsnew/WhatsNew.tsx

svenefftinge · 2021-06-25T06:44:19Z

The main point for this release is to inform everyone who still is using Theia that support is going to be removed. I feel this message gets a little burried within the other information of the "what's new" dialog.

Maybe we switch everyone to VScode and change the button so that people have to opt-out of that switch. They will get the new IDE and in case they did not read the "news" and still want theia they will try to switch back to it where they again get the message that we are removing support end of august.

svenefftinge · 2021-06-25T06:58:19Z

Could you add the deprecation and end-of-life message to the settings page as well?

corneliusludmann · 2021-06-25T10:21:07Z

Could you add the deprecation and end-of-life message to the settings page as well?

Done here: #4614

gtsiolis

Almost there! 🏁

components/dashboard/src/whatsnew/WhatsNew-2021-06.tsx

components/dashboard/src/components/CodeText.tsx

gtsiolis

Left behind these two minor comments! 😇

components/dashboard/src/whatsnew/WhatsNew-2021-06.tsx

corneliusludmann · 2021-06-25T16:02:46Z

Hey @gtsiolis! Thanks a lot for all your input! ❤️

I've updated the PR as well as the PR description above with latest screenshots.

I noticed that the monospaced code texts overlap a bit with the text in the line above and below. If you have a quick fix for this handy, I can address this in this PR as well. Otherwise, I would vote for creating an issue and addressing this in a follow-up PR.

gtsiolis

Thanks for pushing this through the finish line @corneliusludmann!

Didn't manage to connect to the database but left some comments inline.

Shall we also remove the #3956 from the PR description and tackle this separately?

components/dashboard/src/components/CodeText.tsx

components/dashboard/src/whatsnew/WhatsNew.tsx

gtsiolis · 2021-06-25T16:50:38Z

components/dashboard/src/whatsnew/WhatsNew.tsx

+                        <button className="ml-2 mt-0 secondary" onClick={internalClose}>Dismiss All</button>
+                        <div className="flex flex-col items-center">
+                            <button className="ml-2" onClick={next}>Next</button>
+                            <div className="text-xs italic mt-1 ml-2 -mb-2">({unseenEntries.length} left)</div>


thought: Thinking whether we could just drop this part. Maybe something to consider in #3956. 💭

components/dashboard/src/whatsnew/WhatsNew.tsx

components/dashboard/src/whatsnew/WhatsNew-2021-06.tsx

components/dashboard/src/whatsnew/WhatsNew.tsx

corneliusludmann · 2021-06-25T18:46:22Z

I've updated the PR. When we agree on the 2 left items we are ready to merge this on Monday. 🚀

components/dashboard/src/whatsnew/WhatsNew-2021-06.tsx

gtsiolis · 2021-06-28T07:12:40Z

Thanks for the updates, @corneliusludmann! Left two comments for the unresolved discussions. 💬

Friendly reminder to remove #3956 from the PR description as this contains suggestions out of the scope of this PR! Let me know if this you think this is not needed. 🎗️

corneliusludmann · 2021-06-28T07:30:44Z

Friendly reminder to remove #3956 from the PR description as this contains suggestions out of the scope of this PR! Let me know if this you think this is not needed.

Since it is not tagged with the Fixes keyword it should be fine to have it linked in the descriptions (it does not close the issue), right?

gtsiolis · 2021-06-28T07:35:46Z

... it should be fine to have it linked in the descriptions ...

Absolutely! It's always helpful to have linked references like this. Thanks, @corneliusludmann! 🙏

corneliusludmann · 2021-06-28T07:49:18Z

Thanks again, @gtsiolis!

Updated PR based on your comments.
No TODOs in the code left. 😇
Rebased on main.
Quick test of the preview env.

I think we are ready to merge. Any last-minute objections?

gtsiolis · 2021-06-28T08:36:47Z

Any last-minute objections?

LET'S DO MERGE THIS.

gtsiolis reviewed Jun 24, 2021

View reviewed changes

components/dashboard/src/whatsnew/WhatsNew-2021-06.tsx Outdated Show resolved Hide resolved

components/dashboard/src/whatsnew/WhatsNew.tsx Show resolved Hide resolved

corneliusludmann force-pushed the clu/theia-add-a-deprecation-4459 branch 2 times, most recently from 3f31a3f to 3c98f8c Compare June 25, 2021 09:28

gtsiolis added the component: dashboard label Jun 25, 2021

corneliusludmann force-pushed the clu/theia-add-a-deprecation-4459 branch from 3c98f8c to ec71cdb Compare June 25, 2021 10:14

corneliusludmann force-pushed the clu/theia-add-a-deprecation-4459 branch from ec71cdb to 2cc38d6 Compare June 25, 2021 11:47

gtsiolis approved these changes Jun 25, 2021

View reviewed changes

components/dashboard/src/whatsnew/WhatsNew-2021-06.tsx Outdated Show resolved Hide resolved

components/dashboard/src/components/CodeText.tsx Outdated Show resolved Hide resolved

corneliusludmann force-pushed the clu/theia-add-a-deprecation-4459 branch from 2cc38d6 to c3546de Compare June 25, 2021 12:28

gtsiolis reviewed Jun 25, 2021

View reviewed changes

components/dashboard/src/whatsnew/WhatsNew-2021-06.tsx Outdated Show resolved Hide resolved

components/dashboard/src/whatsnew/WhatsNew-2021-06.tsx Outdated Show resolved Hide resolved

corneliusludmann force-pushed the clu/theia-add-a-deprecation-4459 branch 2 times, most recently from 77525b2 to fdd62eb Compare June 25, 2021 15:00

gtsiolis reviewed Jun 25, 2021

View reviewed changes

components/dashboard/src/whatsnew/WhatsNew-2021-06.tsx Show resolved Hide resolved

corneliusludmann force-pushed the clu/theia-add-a-deprecation-4459 branch from fdd62eb to b215475 Compare June 25, 2021 15:33

corneliusludmann marked this pull request as ready for review June 25, 2021 16:02

gtsiolis approved these changes Jun 25, 2021

View reviewed changes

gtsiolis reviewed Jun 25, 2021

View reviewed changes

components/dashboard/src/whatsnew/WhatsNew.tsx Outdated Show resolved Hide resolved

corneliusludmann force-pushed the clu/theia-add-a-deprecation-4459 branch from b215475 to 94c838b Compare June 25, 2021 17:04

gtsiolis reviewed Jun 25, 2021

View reviewed changes

components/dashboard/src/whatsnew/WhatsNew.tsx Outdated Show resolved Hide resolved

corneliusludmann force-pushed the clu/theia-add-a-deprecation-4459 branch from 94c838b to b9ccf78 Compare June 25, 2021 18:41

corneliusludmann commented Jun 26, 2021

View reviewed changes

components/dashboard/src/whatsnew/WhatsNew-2021-06.tsx Outdated Show resolved Hide resolved

[dashboard] Introduce component CodeText

b8eb279

corneliusludmann force-pushed the clu/theia-add-a-deprecation-4459 branch from b9ccf78 to 31b03dc Compare June 28, 2021 07:38

[dashboard] Refactor What's New dialog

b3e2569

corneliusludmann force-pushed the clu/theia-add-a-deprecation-4459 branch from 31b03dc to b3e2569 Compare June 28, 2021 07:40

corneliusludmann merged commit e2bf23a into main Jun 28, 2021

corneliusludmann deleted the clu/theia-add-a-deprecation-4459 branch June 28, 2021 08:37

gtsiolis mentioned this pull request Aug 9, 2021

Add What's New entry for teams and projects #5126

Closed

gtsiolis mentioned this pull request Sep 6, 2021

Change default branch label colors for dark theme #5556

Merged

gtsiolis mentioned this pull request Oct 11, 2021

'Beta' tag in UI for new teams and projects #6010

Closed

This was referenced Jan 10, 2022

[dashboard] show repo name when workspace creation fails #7302

Merged

Improve warning alert component design #7613

Closed

gtsiolis mentioned this pull request Apr 26, 2022

Allow user to configure IDE configurations when onboarding start workspace #9534

Closed

gtsiolis mentioned this pull request Feb 13, 2023

Epic: Collect information from users during onboarding #15857

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dashboard] Refactor What's New dialog #4607

[dashboard] Refactor What's New dialog #4607

corneliusludmann commented Jun 24, 2021 •

edited

Loading

gtsiolis left a comment

svenefftinge commented Jun 25, 2021 •

edited

Loading

svenefftinge commented Jun 25, 2021

corneliusludmann commented Jun 25, 2021

gtsiolis left a comment

gtsiolis left a comment

corneliusludmann commented Jun 25, 2021

gtsiolis left a comment •

edited

Loading

gtsiolis Jun 25, 2021

corneliusludmann commented Jun 25, 2021

gtsiolis commented Jun 28, 2021 •

edited by werft-gitpod-dev-com bot

Loading

corneliusludmann commented Jun 28, 2021

gtsiolis commented Jun 28, 2021 •

edited by werft-gitpod-dev-com bot

Loading

corneliusludmann commented Jun 28, 2021

gtsiolis commented Jun 28, 2021 •

edited

Loading

[dashboard] Refactor What's New dialog #4607

[dashboard] Refactor What's New dialog #4607

Conversation

corneliusludmann commented Jun 24, 2021 • edited Loading

That's how it looks like for an active user that has already VSCode as editor:

That's how it looks like for an active user that still has Theia as editor:

That's how it looks like for a user that has not been seen the previous “What's New” message because he/she has not logged in since then.

gtsiolis left a comment

Choose a reason for hiding this comment

svenefftinge commented Jun 25, 2021 • edited Loading

svenefftinge commented Jun 25, 2021

corneliusludmann commented Jun 25, 2021

gtsiolis left a comment

Choose a reason for hiding this comment

gtsiolis left a comment

Choose a reason for hiding this comment

corneliusludmann commented Jun 25, 2021

gtsiolis left a comment • edited Loading

Choose a reason for hiding this comment

gtsiolis Jun 25, 2021

Choose a reason for hiding this comment

corneliusludmann commented Jun 25, 2021

gtsiolis commented Jun 28, 2021 • edited by werft-gitpod-dev-com bot Loading

corneliusludmann commented Jun 28, 2021

gtsiolis commented Jun 28, 2021 • edited by werft-gitpod-dev-com bot Loading

corneliusludmann commented Jun 28, 2021

gtsiolis commented Jun 28, 2021 • edited Loading

corneliusludmann commented Jun 24, 2021 •

edited

Loading

svenefftinge commented Jun 25, 2021 •

edited

Loading

gtsiolis left a comment •

edited

Loading

gtsiolis commented Jun 28, 2021 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Jun 28, 2021 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Jun 28, 2021 •

edited

Loading