Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] deprecate user uploaded extensions #4627

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Jun 27, 2021

What it does

It contains #4580 so should be merged afterwards.

Changes in Gitpod Code: gitpod-io/openvscode-server@19c309e

How to test

vscode:
  extensions:
    - hangxingliu.vscode-nginx-conf-hint@0.1.0:UATTe2sTFfCYWQ3jw4IRsw==
    - zxh404.vscode-proto3@0.4.2:ZnPmyF/Pb8AIWeCqc83gPw==
    - ms-kubernetes-tools.vscode-kubernetes-tools@1.2.1:j58HdmA0K7d9a9sEkogZNw==
    - bajdzis.vscode-database@2.2.1:uXdjV53wtoTevFK6HOh3pQ==
    - hashicorp.terraform@2.1.1:QEP7gdWtMuY+j8RZ5OLDkA==
    - stkb.rewrap@1.13.0:yEx8nRSXlfXAHqsbkTJpdA==
    - golang.go@0.14.4:Z3iqHRuIxskc0nruY4MpEQ==
    - https://github.com/golang/vscode-go/releases/download/v0.26.0/go-0.26.0.vsix
    - https://github.com/golang/vscode-go/releases/download2/v0.26.0/go-0.26.222.vsix
  • You should see a warning that user uploaded extensions are deprecated and a quick fix to resolve them all against Open VSX.
  • Now add some invalid extensions in .gitpod.yml, you should get an error that an extension cannot be resolved.
    • Valid extension is either URL pointing to vsix file, just id, i.e. golang.go, or id@full-version, i.e. golang.go@0.14.4, everything else is invalid, i.e. golang.go@0

@akosyakov akosyakov force-pushed the ak/deprecate_user_extensions branch 2 times, most recently from fa43e04 to 6bfa9e2 Compare June 28, 2021 06:23
@akosyakov akosyakov marked this pull request as ready for review June 28, 2021 06:57
Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Awesome features!

@akosyakov akosyakov force-pushed the ak/deprecate_user_extensions branch from 6bfa9e2 to df342cf Compare June 28, 2021 08:46
@akosyakov akosyakov merged commit c96e30e into main Jun 28, 2021
@akosyakov akosyakov deleted the ak/deprecate_user_extensions branch June 28, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code: deprecate user uploaded extensions
2 participants