Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] Update tailwindcss and enable jit (now stable) #4655

Merged
merged 1 commit into from
Aug 23, 2021
Merged

[dashboard] Update tailwindcss and enable jit (now stable) #4655

merged 1 commit into from
Aug 23, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 29, 2021

No description provided.

@aledbf aledbf marked this pull request as ready for review July 12, 2021 10:45
@aledbf aledbf requested a review from a team as a code owner July 12, 2021 10:45
@aledbf aledbf requested review from a team and jankeromnes and removed request for a team July 12, 2021 10:45
@csweichel
Copy link
Contributor

/assign @AlexTugarev

@jankeromnes jankeromnes requested review from AlexTugarev and removed request for a team and jankeromnes August 13, 2021 13:11
@AlexTugarev
Copy link
Member

AlexTugarev commented Aug 23, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-aledbf-tailwind.1

@aledbf
Copy link
Member Author

aledbf commented Aug 23, 2021

@AlexTugarev I rebased the PR. Please check now.

@AlexTugarev
Copy link
Member

/lgtm
/approve no-issue

Thanks @aledbf! It seems to works nicely in our setup. Perf is good and I'm looking forward to use the use extra styles on the fly with jit.

@roboquat roboquat added the lgtm label Aug 23, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 611c043a1633a7527e34d670c817cb04e2800e40

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexTugarev

Associated issue requirement bypassed by: AlexTugarev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 4d82225 into main Aug 23, 2021
@roboquat roboquat deleted the aledbf/tailwind branch August 23, 2021 14:39
@gtsiolis
Copy link
Contributor

Looping in the rest of the teams and projects crew for visibility of this change. Cc @jankeromnes @svenefftinge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexTugarev AlexTugarev Awaiting requested review from AlexTugarev

Assignees

@AlexTugarev AlexTugarev

Labels
approved component: dashboard size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aledbf @csweichel @AlexTugarev @roboquat @gtsiolis