fix(components/server): ensure a sane redirect/returnTo query param #4708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leodido
requested review from
a team and
jankeromnes
and removed request for
a team
|
/werft run 馃憤 started the job as gitpod-build-leo-safe-redirect-query-param.1 |
AlexTugarev
requested changes
Jul 6, 2021
There was a problem hiding this comment.
@leodido it's awesome that you're on it to fix the situation! 馃挴
I believe it will be more sustainable to not allow addressing any hosts at all. We should rather rewrite all returnTo=URL with returnTo=PATH with the means of appending the path to the known Gitpod host. This way there is no need to parse user values as URL.
AlexTugarev
reviewed
Jul 6, 2021
|
@AlexTugarev thanks for your feeback! Would you please take another look at it? :) |
|
/werft run 馃憤 started the job as gitpod-build-leo-safe-redirect-query-param.3 |
AlexTugarev
reviewed
Jul 6, 2021
AlexTugarev
approved these changes
Jul 6, 2021
|
/werft run 馃憤 started the job as gitpod-build-leo-safe-redirect-query-param.4 |
|
@leodido could you rebase please? |
Signed-off-by: Leo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
leodido
force-pushed
the
leo/safe-redirect-query-param
branch
from
fa0087a
to
b923636
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Leo Di Donato leodidonato@gmail.com
This PR ensures the value of the
redirect(orreturnTo) query parameter is safe.To do so, it strictly checks the value against the allowed URLs (rather than relying on
startsWith).Furthermore, it uses the
URLinterface to ensure URLs are normalized before checking them.On a side note
My first PR! 馃巿
Also, my first Typescript code in years and years (literally!) ... 馃槉
So please be gentle with me 馃檱