[server] Add kube-rbac-proxy rolebinding to SA #4745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurSens
suggested changes
Jul 8, 2021
| kind: ClusterRoleBinding | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| metadata: | ||
| name: {{ .Release.Namespace }}-agent-smith-rb-kube-rbac-proxy |
There was a problem hiding this comment.
Suggested change
| name: {{ .Release.Namespace }}-agent-smith-rb-kube-rbac-proxy | |
| name: {{ .Release.Namespace }}-server-rb-kube-rbac-proxy |
| name: {{ .Release.Namespace }}-agent-smith-rb-kube-rbac-proxy | ||
| labels: | ||
| app: {{ template "gitpod.fullname" . }} | ||
| component: agent-smith |
There was a problem hiding this comment.
Suggested change
| component: agent-smith | |
| component: server |
| stage: {{ .Values.installation.stage }} | ||
| subjects: | ||
| - kind: ServiceAccount | ||
| name: agent-smith |
There was a problem hiding this comment.
Suggested change
| name: agent-smith | |
| name: server |
|
Good catch - I was a bit too quick here. Will fix |
csweichel
force-pushed
the
csweichel/server-metrics-are-broken-4739
branch
from
98b0bd6
to
9338461
Compare
ArthurSens
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server metrics scraping is broken because of a missing role binding:
fixes #4739
/werft no-preview