[server] Fix HTTP endpoint metrics #4751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csweichel
requested review from
a team and
corneliusludmann
and removed request for
a team
csweichel
force-pushed
the
csweichel/server-produce-metrics-4741
branch
from
c426a6a
to
a1a7269
Compare
corneliusludmann
approved these changes
Jul 8, 2021
That is expected indeed. It's the same behaviour we've seen from caddy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the HTTP endpoint metrics on server, and makes them work for websocket connections.
How to test
/api/version)gitpod_server_http_requests_*fixes #4741