[local-companion-app] Fix ssh_config generation on Windows

[csweichel]

fixes #4768

This PR fixes the ssh_config file generation on Windows by introducing a more sensible default to the --ssh-config flag. Instead of hardcoding /tmp it defaults to os.TmpDir() if the GOOS == "windows".

fixes #4759

In addition, this PR introduces fresh SSH keypair generation for each workspace. This way we don't rely on the user having a keypair generated already, and don't spread the user's id_rsa.pub content around. Also, the SSH public key upload is now properly synchronised (before it was just time.Sleep(500 * time.Millisecond)).

How to test

1. Download the local app build from this branch
2. Run the local app (e.g. against prod).
3. SSH'ing into your workspace should work OOTB

[akosyakov]

@jmcelreavey @extrawurst Could you please give it a try?

# mac
curl -OL https://csweichel-gitpod-local-companion-4768.staging.gitpod-dev.com/static/bin/gitpod-local-companion-darwin
chmod +x ./gitpod-local-companion-darwin
./gitpod-local-companion-darwin --mock-keyring

# linux
# curl -OL https://csweichel-gitpod-local-companion-4768.staging.gitpod-dev.com/static/bin/gitpod-local-companion-linux
chmod +x ./gitpod-local-companion-linux
./gitpod-local-companion-linux --mock-keyring

# windows
# curl -OL https://csweichel-gitpod-local-companion-4768.staging.gitpod-dev.com/static/bin/gitpod-local-companion-windows.exe
./gitpod-local-companion-windows.exe --mock-keyring

[akosyakov]

works well

[leodido]

Works like a charm! Thank you! 👏

[jmcelreavey]

Sorry the links above no longer work. How do I go about generating a new .exe file? :)

[akosyakov]

It should be deployed soon, you also can do following:

• open a new workspace https://gitpod.io/#https://github.com/gitpod-io/gitpod
• run leeway build components/local-app:app-windows --serve=:8080
• press open in browser for 8080 when notification appears and download latest distributable, i.e. local-app.exe

[jmcelreavey]

It should be deployed soon, you also can do following:

• open a new workspace https://gitpod.io/#https://github.com/gitpod-io/gitpod
• run leeway build components/local-app:app-windows --serve=:8080
• press open in browser for 8080 when notification appears and download latest distributable, i.e. local-app.exe

You sir are a true hero, that worked perfectly! Thanks. 👍