Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Set owner token cookie HttpOnly and Secure #4832

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

csweichel
Copy link
Contributor

@csweichel csweichel commented Jul 15, 2021

Prior the owner token could be read by a VS Code extension or a website served from a port.
Granted, not a very useful thing to do especially in the latter case, because you're already in the workspace then.

fixes #4830

@csweichel csweichel requested a review from akosyakov July 15, 2021 09:47
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #4832 (31d2ad6) into main (92a11b1) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4832      +/-   ##
==========================================
- Coverage   35.94%   35.92%   -0.03%     
==========================================
  Files          78       78              
  Lines       15484    15484              
==========================================
- Hits         5566     5562       -4     
- Misses       9432     9437       +5     
+ Partials      486      485       -1     
Flag Coverage Δ
components-content-service-app 14.35% <ø> (ø)
components-content-service-lib 14.35% <ø> (ø)
components-ee-ws-scheduler-app 62.68% <ø> (-0.17%) ⬇️
components-image-builder-api-go-lib ∅ <ø> (∅)
components-image-builder-app 34.44% <ø> (ø)
components-local-app-app-darwin ?
components-local-app-app-linux ?
components-local-app-app-windows ?
components-supervisor-app 36.21% <ø> (-0.08%) ⬇️
components-workspacekit-app ∅ <ø> (∅)
components-ws-daemon-api-go-lib ∅ <ø> (∅)
components-ws-daemon-app 22.29% <ø> (ø)
components-ws-daemon-nsinsider-app ∅ <ø> (∅)
components-ws-manager-api-go-lib ∅ <ø> (∅)
components-ws-manager-app 36.68% <ø> (ø)
components-ws-proxy-app 65.84% <ø> (+0.16%) ⬆️
dev-loadgen-app ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ee/ws-scheduler/pkg/scheduler/state.go 90.46% <0.00%> (-0.99%) ⬇️
components/supervisor/pkg/ports/ports.go 59.85% <0.00%> (-0.36%) ⬇️
components/supervisor/pkg/terminal/terminal.go 64.19% <0.00%> (-0.31%) ⬇️
components/ws-proxy/pkg/proxy/infoprovider.go 50.34% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92a11b1...31d2ad6. Read the comment docs.

@akosyakov
Copy link
Member

akosyakov commented Jul 16, 2021

/werft run

👍 started the job as gitpod-build-csweichel-mark-owner-token-as-http-4830.1

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as advertised

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akosyakov, csweichel
To complete the pull request process, please assign jankoehnlein after the PR has been reviewed.
You can assign the PR to them by writing /assign @jankoehnlein in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csweichel csweichel merged commit 42618d6 into main Jul 16, 2021
@csweichel csweichel deleted the csweichel/mark-owner-token-as-http-4830 branch July 16, 2021 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mark owner token as http only
3 participants