Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] Fix email notifications checkbox #4870

Merged
merged 1 commit into from
Jul 20, 2021
Merged

[dashboard] Fix email notifications checkbox #4870

merged 1 commit into from
Jul 20, 2021

Conversation

corneliusludmann
Copy link
Contributor

Fixes #4755

@corneliusludmann
Copy link
Contributor Author

Used the useState/useRef pattern here. If you have an idea for a better implementation, please let me know.

AlexTugarev
AlexTugarev reviewed Jul 20, 2021
View reviewed changes
Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useState should solve the issue.

components/dashboard/src/settings/Notifications.tsx Outdated Show resolved Hide resolved
components/dashboard/src/settings/Notifications.tsx Outdated Show resolved Hide resolved
components/dashboard/src/settings/Notifications.tsx Outdated Show resolved Hide resolved
components/dashboard/src/settings/Notifications.tsx Show resolved Hide resolved
components/dashboard/src/settings/Notifications.tsx Show resolved Hide resolved
components/dashboard/src/settings/Notifications.tsx Outdated Show resolved Hide resolved
@corneliusludmann corneliusludmann force-pushed the corneliusludmann/changes-to-email-4755 branch from fb65b65 to c847d14 Compare July 20, 2021 09:20
AlexTugarev
AlexTugarev approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely!

@roboquat roboquat added the lgtm label Jul 20, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4c3778583f7ecc44ff318ee528a4c4a5085986bf

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexTugarev, corneliusludmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 264071f into main Jul 20, 2021
@roboquat roboquat deleted the corneliusludmann/changes-to-email-4755 branch July 20, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexTugarev AlexTugarev AlexTugarev approved these changes

Assignees

@AlexTugarev AlexTugarev

Labels
approved size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

changes to email notifications in the dashboard are not displayed correctly
3 participants
@corneliusludmann @roboquat @AlexTugarev